Compare commits

...

9 Commits

Author SHA1 Message Date
Sergey Chebotar
8b125e475e Tune amount column find 2023-06-06 08:17:52 +03:00
Sergey Chebotar
0e15ad7cd4 Continue instead of false return on value > maxValue 2023-05-30 09:08:11 +03:00
Sergey Chebotar
f6534fc8c7 Refactoring 2023-05-30 09:01:49 +03:00
Sergey Chebotar
51636ca61a Can guess single row with string headers 2023-05-30 08:59:16 +03:00
Sergey Chebotar
f1abb03ac9 Can guess amount columns with numbers in header 2023-05-30 08:48:21 +03:00
Sergey Chebotar
656f565152 Edit Guess Reader test 2023-05-30 08:47:16 +03:00
Sergey Chebotar
ab217c9052 Throw exceptions on unknown Service or Tool 2023-05-30 08:23:31 +03:00
Sergey Chebotar
65d027179c Refactoring 2023-05-27 08:58:23 +03:00
Sergey Chebotar
f620147515 Change DateTime from Now to Today 2023-05-27 08:58:09 +03:00
8 changed files with 46 additions and 39 deletions

View File

@ -161,7 +161,7 @@ public class RhSolutionsFunction
.GetResult() .GetResult()
.FirstOrDefault(); .FirstOrDefault();
DateTime date = dateField == 0 ? DateTime.Now : DateTime.FromOADate(dateField); DateTime date = dateField == 0 ? DateTime.Today : DateTime.FromOADate(dateField);
var exchangeRate = currencyClient.GetCurrencyCourse(date) var exchangeRate = currencyClient.GetCurrencyCourse(date)
.GetAwaiter() .GetAwaiter()
.GetResult(); .GetResult();
@ -193,7 +193,7 @@ public class RhSolutionsFunction
if (ExcelAsyncUtil.Run("Database request", dateField, delegate if (ExcelAsyncUtil.Run("Database request", dateField, delegate
{ {
DateTime date = dateField == 0 ? DateTime.Now : DateTime.FromOADate(dateField); DateTime date = dateField == 0 ? DateTime.Today : DateTime.FromOADate(dateField);
var exchangeRate = currencyClient.GetCurrencyCourse(date) var exchangeRate = currencyClient.GetCurrencyCourse(date)
.GetAwaiter() .GetAwaiter()
.GetResult(); .GetResult();

View File

@ -84,7 +84,7 @@ public class RibbonController : ExcelRibbon
public bool GetConvertEnabled(IRibbonControl control) => _workbookIsValid; public bool GetConvertEnabled(IRibbonControl control) => _workbookIsValid;
public bool GetDxfEnabled(IRibbonControl control) => _workbookIsValid; public bool GetDxfEnabled(IRibbonControl control) => _workbookIsValid;
public bool GetGuessEnabled(IRibbonControl control) => RhSolutionsAddIn.Excel.ActiveWorkbook == null ? false : !_workbookIsValid; public bool GetGuessEnabled(IRibbonControl control) => RhSolutionsAddIn.Excel.ActiveWorkbook != null && !_workbookIsValid;
public bool GetExportEnabled(IRibbonControl control) public bool GetExportEnabled(IRibbonControl control)
{ {

View File

@ -1,5 +1,4 @@
using Microsoft.Office.Interop.Excel; using System.IO;
using System.IO;
namespace RhSolutions.Services; namespace RhSolutions.Services;
@ -47,19 +46,21 @@ public class GuessReader : IReader
} }
if (currentIndex > productColumnIndex) if (currentIndex > productColumnIndex)
{ {
if (IsAmountColumn(range.Columns[currentIndex++])) if (IsAmountColumn(range.Columns[currentIndex]))
{ {
amountColumnIndex = currentIndex - 1; amountColumnIndex = currentIndex;
break; break;
} }
else currentIndex++;
} }
else else
{ {
if (IsAmountColumn(range.Columns[currentIndex--])) if (IsAmountColumn(range.Columns[currentIndex]))
{ {
amountColumnIndex = currentIndex + 1; amountColumnIndex = currentIndex;
break; break;
} }
else currentIndex--;
} }
} }
@ -93,7 +94,7 @@ public class GuessReader : IReader
continue; continue;
} }
if (ProductSku.TryParse(currentCell.ToString(), out IEnumerable<ProductSku> skus)) if (ProductSku.TryParse(currentCell.ToString(), out _))
{ {
successCounter++; successCounter++;
} }
@ -111,39 +112,43 @@ public class GuessReader : IReader
{ {
int successCounter = 0; int successCounter = 0;
var cells = column.Value2; var cells = column.Value2;
double maxValue = 30000;
if (cells == null) if (cells == null)
{ {
return false; return false;
} }
for (int row = 1; row < column.Rows.Count + 1; row++) if (column.Rows.Count == 1)
{ {
object currentCell = column.Rows.Count == 1 ? cells : cells[row, 1]; double? value = cells as double?;
if (currentCell == null)
{
continue;
}
double? value = currentCell as double?; return value != null
&& value != 0
if (value == null || value == 0) && value < maxValue;
{
continue;
}
if (value > 30000)
{
return false;
}
if (++successCounter > 3)
{
return true;
}
} }
return successCounter > 0; else
{
for (int row = 1; row < column.Rows.Count + 1; row++)
{
object currentCell = cells[row, 1];
double? value = currentCell as double?;
if (value == null
|| value == 0
|| value > maxValue)
{
continue;
}
if (++successCounter > 3)
{
return true;
}
}
}
return successCounter > 1;
} }
private Dictionary<Product, double> GetDictionaryFromColumns(Range productColumn, Range amountColumn) private Dictionary<Product, double> GetDictionaryFromColumns(Range productColumn, Range amountColumn)

View File

@ -15,7 +15,7 @@ public class ReaderFactory
{ {
"Guess" => (IReader)_serviceProvider.GetService(typeof(GuessReader)), "Guess" => (IReader)_serviceProvider.GetService(typeof(GuessReader)),
"Excel" => (IReader)_serviceProvider.GetService(typeof(ExcelReader)), "Excel" => (IReader)_serviceProvider.GetService(typeof(ExcelReader)),
_ => (IReader)_serviceProvider.GetService(typeof(ExcelReader)) _ => throw new ArgumentException($"Незвестный интерфейс {nameof(IReader)}: {readerName}")
}; };
} }
} }

View File

@ -15,7 +15,7 @@ public class WriterFactory
{ {
"Excel" => (IWriter)_serviceProvider.GetService(typeof(ExcelWriter)), "Excel" => (IWriter)_serviceProvider.GetService(typeof(ExcelWriter)),
"Dxf" => (IWriter)_serviceProvider.GetService(typeof(DxfWriter)), "Dxf" => (IWriter)_serviceProvider.GetService(typeof(DxfWriter)),
_ => (IWriter)_serviceProvider.GetService(typeof(ExcelWriter)) _ => throw new ArgumentException($"Незвестный интерфейс {nameof(IWriter)}: {writerName}")
}; };
} }
} }

View File

@ -11,7 +11,7 @@ internal class ToolFactory
"merge" => new MergeTool(RhSolutionsAddIn.ServiceProvider), "merge" => new MergeTool(RhSolutionsAddIn.ServiceProvider),
"dxfexport" => new DxfTool(RhSolutionsAddIn.ServiceProvider), "dxfexport" => new DxfTool(RhSolutionsAddIn.ServiceProvider),
"Guessexport" => new GuessTool(RhSolutionsAddIn.ServiceProvider), "Guessexport" => new GuessTool(RhSolutionsAddIn.ServiceProvider),
_ => throw new Exception("Неизвестный инструмент"), _ => throw new Exception($"Неизвестный инструмент {toolName}"),
}; };
return tool; return tool;
} }

View File

@ -8,13 +8,15 @@ namespace RhSolutions.Tests;
public class CanDoGuess : IDisposable public class CanDoGuess : IDisposable
{ {
private RhSolutionsAddIn _addIn; private RhSolutionsAddIn _addIn;
private IReader _guessReader;
private IReader _reader; private IReader _reader;
public CanDoGuess() public CanDoGuess()
{ {
_addIn = new(); _addIn = new();
_addIn.AutoOpen(); _addIn.AutoOpen();
_reader = new GuessReader(Util.Application); _guessReader = new GuessReader(Util.Application);
_reader = new ExcelReader(Util.Application, RhSolutionsAddIn.Configuration);
} }
[ExcelFact(Workbook = @"..\..\..\TestWorkbooks\TestSpecificationGuess.xlsx")] [ExcelFact(Workbook = @"..\..\..\TestWorkbooks\TestSpecificationGuess.xlsx")]
@ -22,7 +24,7 @@ public class CanDoGuess : IDisposable
{ {
Worksheet sourceSheet = Util.Workbook.Worksheets[1]; Worksheet sourceSheet = Util.Workbook.Worksheets[1];
RhSolutionsAddIn.Configuration.SetPriceListPath(Path.GetFullPath(@"..\..\..\TestWorkbooks\TargetSpecificationGuess.xlsx")); RhSolutionsAddIn.Configuration.SetPriceListPath(Path.GetFullPath(@"..\..\..\TestWorkbooks\TargetSpecificationGuess.xlsx"));
var products = _reader.ReadProducts(new[] { sourceSheet }); var products = _guessReader.ReadProducts(new[] { sourceSheet });
var _writer = new ExcelWriter(Util.Application, RhSolutionsAddIn.Configuration); var _writer = new ExcelWriter(Util.Application, RhSolutionsAddIn.Configuration);
_writer.WriteProducts(products); _writer.WriteProducts(products);
Worksheet targetSheet = Util.Application.ActiveWindow.ActiveSheet; Worksheet targetSheet = Util.Application.ActiveWindow.ActiveSheet;
@ -39,7 +41,7 @@ public class CanDoGuess : IDisposable
{ {
Worksheet sourceSheet = Util.Workbook.Worksheets[1]; Worksheet sourceSheet = Util.Workbook.Worksheets[1];
RhSolutionsAddIn.Configuration.SetPriceListPath(Path.GetFullPath(@"..\..\..\TestWorkbooks\TargetSpecificationGuessOneRow.xlsx")); RhSolutionsAddIn.Configuration.SetPriceListPath(Path.GetFullPath(@"..\..\..\TestWorkbooks\TargetSpecificationGuessOneRow.xlsx"));
var products = _reader.ReadProducts(new[] { sourceSheet }); var products = _guessReader.ReadProducts(new[] { sourceSheet });
var _writer = new ExcelWriter(Util.Application, RhSolutionsAddIn.Configuration); var _writer = new ExcelWriter(Util.Application, RhSolutionsAddIn.Configuration);
_writer.WriteProducts(products); _writer.WriteProducts(products);
Worksheet targetSheet = Util.Application.ActiveWindow.ActiveSheet; Worksheet targetSheet = Util.Application.ActiveWindow.ActiveSheet;